-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kdb+ plugin uses unsafe C++ code #14
Comments
FlyingOE
pushed a commit
to FlyingOE/DolphinDBPlugin
that referenced
this issue
Aug 16, 2023
- fixed memory leak upload qIPC call - removed unsafe use of std::string::c_str() - refactored kdb+ object parser
FlyingOE
pushed a commit
to FlyingOE/DolphinDBPlugin
that referenced
this issue
Aug 16, 2023
- fixed memory leak upon initial qIPC call - removed unsafe use of std::string::c_str() - refactored kdb+ object parser
There is also potential memory leak upon initial qIPC call in DolphinDBPlugin/kdb/src/kdb.cpp Line 95 in 6bbadf9
DolphinDBPlugin/kdb/src/kdb.cpp Line 108 in 6bbadf9
|
FlyingOE
pushed a commit
to FlyingOE/DolphinDBPlugin
that referenced
this issue
Aug 17, 2023
- detect potential problems with variadic function calls - avoided potential memory leak
This is not exception-safe: DolphinDBPlugin/kdb/src/kdb.cpp Line 1307 in 6bbadf9
|
FlyingOE
pushed a commit
to FlyingOE/DolphinDBPlugin
that referenced
this issue
Sep 1, 2023
…data structures; add support for nested (2-dimensional) column types. WIP: remove legacy copy-and-paste code fragments; further streamline parsing of kdb+ data files.
FlyingOE
pushed a commit
to FlyingOE/DolphinDBPlugin
that referenced
this issue
Sep 14, 2023
…d support for nested table columns
FlyingOE
pushed a commit
to FlyingOE/DolphinDBPlugin
that referenced
this issue
Sep 18, 2023
…ing simple nested types.
FlyingOE
pushed a commit
to FlyingOE/DolphinDBPlugin
that referenced
this issue
Sep 18, 2023
…played table columns
FlyingOE
pushed a commit
to FlyingOE/DolphinDBPlugin
that referenced
this issue
Sep 18, 2023
…compressed data files
FlyingOE
pushed a commit
to FlyingOE/DolphinDBPlugin
that referenced
this issue
Sep 18, 2023
FlyingOE
pushed a commit
to FlyingOE/DolphinDBPlugin
that referenced
this issue
Sep 18, 2023
- kdbConnectionOnClose cannot throw - kdb+ data trailer detection
FlyingOE
pushed a commit
to FlyingOE/DolphinDBPlugin
that referenced
this issue
Sep 19, 2023
FlyingOE
pushed a commit
to FlyingOE/DolphinDBPlugin
that referenced
this issue
Oct 23, 2023
…data structures; add support for nested (2-dimensional) column types. WIP: remove legacy copy-and-paste code fragments; further streamline parsing of kdb+ data files.
FlyingOE
pushed a commit
to FlyingOE/DolphinDBPlugin
that referenced
this issue
Oct 23, 2023
…d support for nested table columns
FlyingOE
pushed a commit
to FlyingOE/DolphinDBPlugin
that referenced
this issue
Oct 23, 2023
…ing simple nested types.
FlyingOE
pushed a commit
to FlyingOE/DolphinDBPlugin
that referenced
this issue
Oct 23, 2023
…played table columns
FlyingOE
pushed a commit
to FlyingOE/DolphinDBPlugin
that referenced
this issue
Oct 23, 2023
…compressed data files
FlyingOE
pushed a commit
to FlyingOE/DolphinDBPlugin
that referenced
this issue
Oct 23, 2023
FlyingOE
pushed a commit
to FlyingOE/DolphinDBPlugin
that referenced
this issue
Oct 23, 2023
- kdbConnectionOnClose cannot throw - kdb+ data trailer detection
FlyingOE
pushed a commit
to FlyingOE/DolphinDBPlugin
that referenced
this issue
Oct 23, 2023
FlyingOE
pushed a commit
to FlyingOE/DolphinDBPlugin
that referenced
this issue
Oct 23, 2023
FlyingOE
pushed a commit
to FlyingOE/DolphinDBPlugin
that referenced
this issue
Oct 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Assigning the result of str.c_str() to a pointer to be used later is against the C++ standard and is not safe. For example:
DolphinDBPlugin/kdb/src/kdb.cpp
Line 61 in 30535a5
The text was updated successfully, but these errors were encountered: