add stream-based rabbit mq bus #484
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
catcherwong
requested changes
Sep 8, 2023
| /// <summary> | ||
| /// Gets or sets the name of the queue. | ||
| /// </summary> | ||
| /// <value>The name of the queue.</value> | ||
| public string QueueName { get; set; } = ""; | ||
| public Action<string> _logger { get; set; } = null; |
|
|
||
| _subConnection.ConnectionShutdown += (_, e) => | ||
| { | ||
| _options._logger?.Invoke($"ERROR: ConnectionShutdown: {e.ReplyText}"); |
There was a problem hiding this comment.
Using ILogger directly may be better here.
sarmis
force-pushed
the
rmq-stream-merge-branch
branch
from
2fb4bc5
to
93c7bf8
Compare
sarmis
force-pushed
the
rmq-stream-merge-branch
branch
from
93c7bf8
to
c74ad32
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit introduces a new messaging bus based on RabbitMQ streams. Using RMQ streams is more efficient for installations with a large number of nodes.