Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecation warnings from dry-configurable #151

Open
ZimbiX opened this issue Feb 8, 2022 · 3 comments
Open

Deprecation warnings from dry-configurable #151

ZimbiX opened this issue Feb 8, 2022 · 3 comments

Comments

@ZimbiX
Copy link

ZimbiX commented Feb 8, 2022

I'm seeing warnings, as it appears dry-configurable deprecated a couple of things without dry-view having been updated.

/usr/local/bundle/ruby/2.7.0/gems/dry-view-0.7.1/lib/dry/view.rb:36:in `<module:Dry>' [dry-configurable] default value as positional argument to settings is deprecated and will be removed in the next major version
Provide a `default:` keyword argument instead

/usr/local/bundle/ruby/2.7.0/gems/dry-view-0.7.1/lib/dry/view.rb:36:in `<module:Dry>' [dry-configurable] passing a constructor as a block is deprecated and will be removed in the next major version
Provide a `constructor:` keyword argument instead

For the latter, keyword arguments are now needed instead of passing a block, e.g. here

@timriley
Copy link
Member

timriley commented Feb 9, 2022

Hey @ZimbiX! dry-view development has essentially moved over to hanami/view, but I'd be more than happy to cut a release with these dry-configurable deprecations addressed, if you're OK to submit a PR here based on hanami/view#190 😄

@ZimbiX
Copy link
Author

ZimbiX commented Feb 9, 2022

Hiya @timriley =) Ah ha; thanks for the heads up. The changes do look straightforward, and I did consider making them myself. But if this isn't going to keep up with future changes in dry-rb, it might be better that we switch. Hmm, I'll look into it and have a think about what would be the best approach for us.

Thanks for all your work!

@olegykz
Copy link
Contributor

olegykz commented Jul 27, 2022

@timriley please have a look - #153

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants