Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The positivep attribute is degenerate, calculate on the fly #19

Open
karalekas opened this issue May 8, 2020 · 1 comment
Open

The positivep attribute is degenerate, calculate on the fly #19

karalekas opened this issue May 8, 2020 · 1 comment

Comments

@karalekas
Copy link
Member

As I was doing some debugging this week, one of the final things I had to fiddle with before inner blossom expansion started working was the positivep attribute -- even when the tree structure was set up correctly, an incorrect setting for positivep would throw off future recommendations and result in invalid states such as a node having two mates. A node's positivity is entirely determined by local information about the tree it is participating in -- for example, a bare vertex is positive, a vertex with a mate but no master is neither positive nor negative, a vertex with a mate that is also its master is positive, and a vertex with a mate that is also its slave is negative. Thus, there is no need to store an additional boolean positivep -- it opens us up to more possibilities for errors during blossom operations, and it can be calculated on the fly.

@ecpeterson
Copy link
Contributor

I've become bearish on this idea. It's true that this information is redundant, but I'm not convinced it's any simpler to recalculate it on the fly. Also, this reasoning is opposite to what appears in #22 , also about tracking global tree state on participating nodes.

@ecpeterson ecpeterson transferred this issue from another repository Oct 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants