Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SampleRatio class not working for sample sizes below 1000 #69

Open
oleolegka opened this issue Jul 1, 2024 · 1 comment
Open

SampleRatio class not working for sample sizes below 1000 #69

oleolegka opened this issue Jul 1, 2024 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@oleolegka
Copy link

pvalue = scipy.stats.binomtest(k=k, n=n, p=p).pvalue

scipy.stats.binomtest requires that both k and n must be int, but

 k = aggr[treatment].count()
 n = k + aggr[control].count()

returns float

@oleolegka oleolegka changed the title SampleRatio class not working for samples sizes below 1000 SampleRatio class not working for sample sizes below 1000 Jul 1, 2024
@e10v e10v self-assigned this Jul 3, 2024
@e10v e10v added the bug Something isn't working label Jul 3, 2024
@e10v
Copy link
Owner

e10v commented Jul 8, 2024

Fixed in #73. I'll close the issue after releasing the next version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants