-
Notifications
You must be signed in to change notification settings - Fork 459
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not order all Yaml maps by keys, only the Helm values file #2702
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -50,7 +50,7 @@ private void check(RegistryAuth config) { | |
// Since Base64.decodeBase64 handles URL-safe encoding, must explicitly check | ||
// the correct characters are used | ||
assertThat(config.toHeaderValue()) | ||
.isEqualTo("eyJlbWFpbCI6InJvbGFuZEBqb2xva2lhLm9yZyIsInBhc3N3b3JkIjoiIz5zZWNyZXRzPz8iLCJ1c2VybmFtZSI6InJvbGFuZCJ9"); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This was changed because of https://github.com/eclipse/jkube/pull/2702/files#r1495937819. |
||
.isEqualTo("eyJ1c2VybmFtZSI6InJvbGFuZCIsInBhc3N3b3JkIjoiIz5zZWNyZXRzPz8iLCJlbWFpbCI6InJvbGFuZEBqb2xva2lhLm9yZyJ9"); | ||
|
||
String header = new String(Base64.getDecoder().decode(config.toHeaderValue())); | ||
|
||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -42,7 +42,6 @@ public class Serialization { | |
static { | ||
for (ObjectMapper mapper : new ObjectMapper[]{JSON_MAPPER, YAML_MAPPER}) { | ||
mapper.enable(SerializationFeature.INDENT_OUTPUT) | ||
.enable(SerializationFeature.ORDER_MAP_ENTRIES_BY_KEYS) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. According to 2a478d1 (where this was introduced) it's used to order the Helm |
||
.disable(SerializationFeature.WRITE_EMPTY_JSON_ARRAYS) | ||
.disable(SerializationFeature.WRITE_NULL_MAP_VALUES); | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was changed because of https://github.com/eclipse/jkube/pull/2702/files#r1495937819.
Previously it read
{"email":"[email protected]","password":"#>secrets??","username":"roland"}
and now it reads{"username":"roland","password":"#>secrets??","email":"[email protected]"}