Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Status of search.exclude setting #13823

Open
madmini opened this issue Jun 18, 2024 · 1 comment
Open

Status of search.exclude setting #13823

madmini opened this issue Jun 18, 2024 · 1 comment
Labels
preferences issues related to preferences

Comments

@madmini
Copy link

madmini commented Jun 18, 2024

Is the settings property Search: Exclude (search.exclude) planned for Theia IDE? Are there alternatives?
Description in VSCode:

Configure glob patterns for excluding files and folders in fulltext searches and file search in quick open. To exclude files from the recently opened list in quick open, patterns must be absolute (for example **/node_modules/**). Inherits all glob patterns from the Files: Exclude setting.

In #7273 (comment) the sentiment is to add it, but PR #8406 (which would have added it) was closed with the following comment:

Closing in favor of: #8433 which has the minimal changes.

The search.exclude preference can be added at a later time, it should not exist in siw since it is ultimately used in different places such as @theia/file-search as well.

I cannot find another reference to search.exclude after this.

I am asking because the absence of a default value for this property has caused yzhang-gh/vscode-markdown#1357.

@msujew msujew added the preferences issues related to preferences label Jun 18, 2024
@msujew
Copy link
Member

msujew commented Jun 18, 2024

Hey @madmini,

there was probably little need on the adopter side to implement search.exclude in the meantime. If you are interest, please feel free to contribute something in that direction. I'd be happy to review any PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
preferences issues related to preferences
Projects
None yet
Development

No branches or pull requests

2 participants