Unexpected dialog box shown after renaming a binary file

[pisv]

Bug Description:

After a binary file is renamed, a dialog box 'The file is either binary or uses an unsupported text encoding' appears out of the blue, if typescript-language-features is active:

Steps to Reproduce:

1. Make sure that typescript-language-features is active, e.g. by opening a .ts file.
2. Rename a binary file in Theia, such as a .jpg file.

The dialog box is opened immediately after the file is successfully renamed.
Nothing happens after choosing either 'Yes' or 'No' in the dialog.

Additional Information

• Operating System: macOS Ventura, also confirmed on Windows 11 Pro, both Browser/Electron
• Theia Version: 1.50, current master

[pisv]

After the file is renamed, vscode.workspace.openTextDocument is called as a result of a call to UpdateImportsOnFileRenameHandler.getJsTsFileBeingMoved in typescript-language-features.

This eventually triggers the following code in Theia, which shows the dialog box:

theia/packages/filesystem/src/browser/file-resource.ts

Lines 185 to 187 in d6be64b

	} catch (e) {
	if (e instanceof TextFileOperationError && e.textFileOperationResult === TextFileOperationResult.FILE_IS_BINARY) {
	if (await this.shouldOpenAsText(nls.localize('theia/filesystem/fileResource/binaryTitle', 'The file is either binary or uses an unsupported text encoding.'))) {

[pisv]

In VS Code, the call to vscode.workspace.openTextDocument just throws an error in this case.