Fix count/decode error in boolean widget #190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ci skip]
Otherwise you get a traceback when getting the faceted_counter: Traceback (innermost last): Module ZPublisher.WSGIPublisher, line 155, in transaction_pubevents Module ZPublisher.WSGIPublisher, line 337, in publish_module Module ZPublisher.WSGIPublisher, line 255, in publish Module ZPublisher.mapply, line 85, in mapply Module ZPublisher.WSGIPublisher, line 61, in call_object Module eea.facetednavigation.caching.nocache, line 12, in replacement Module eea.facetednavigation.browser.app.counter, line 77, in __call__ Module eea.facetednavigation.browser.app.counter, line 58, in query Module eea.facetednavigation.widgets.widget, line 390, in count AttributeError: 'int' object has no attribute 'decode'
avoinea
approved these changes
Dec 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes issue #111 and #118.
Problem seen on Plone 5.1 and 5.2 with current master:
Note that the boolean widget always has a vocabulary of
[(1,1)], and that is theintobject that causes the traceback.I can't get my head around whether this PR works well for all combinations of "boolean widget plus any index" and "any widget plus boolean index". And I can't get any checkbox widget to appear, with or without this fix. But it works for a boolean widget with a boolean or integer index.