Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ManagedStream: low fps when there are more than two clients #13

Open
egeakman opened this issue Mar 10, 2024 · 3 comments · May be fixed by #6
Open

ManagedStream: low fps when there are more than two clients #13

egeakman opened this issue Mar 10, 2024 · 3 comments · May be fixed by #6
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@egeakman
Copy link
Owner

egeakman commented Mar 10, 2024 •
edited
Loading

#12 might be why

TL;DR: The more tabs you open, the lower fps the stream gets.
@egeakman egeakman added the bug Something isn't working label Mar 10, 2024
egeakman added a commit that referenced this issue Apr 3, 2024
@egeakman
Fix #12 and #13
568ae1d
egeakman added a commit that referenced this issue Apr 5, 2024
@egeakman
#12 and #13 were reintroduced in 1342a95 + remove __new__ override
1c56c86
@egeakman egeakman linked a pull request May 3, 2024 that will close this issue
Draft
@egeakman egeakman linked a pull request May 3, 2024 that will close this issue
[Lib+CLI] On Demand Feature + New Class Structure #6
Draft
egeakman added a commit that referenced this issue May 4, 2024
@egeakman
Add performance test results + #13 fix is validated, it works on Linu…
2ea77e3 
…x too
@egeakman
Copy link
Owner Author

egeakman commented May 5, 2024 •
edited
Loading

Went back to 1c56c86 but couldn't reproduce the issue. It might have been caused by a dependency. I probably should pin the dependencies. note to myself

An old/bad camera also causes this

@egeakman
Copy link
Owner Author

egeakman commented May 8, 2024 •
edited
Loading

This is also related to FPS. If fps is set high too high, the stream handler is called too many times.

If the FPS is set to 60 and we have 5 clients open, then: 60*5=300 calls per second. Even though calls after 60 don't trigger a frame reading and processing, that's still a lot of calls I believe.

I think I need someone more experienced for this one.

@egeakman egeakman added the help wanted Extra attention is needed label May 8, 2024
@egeakman
Copy link
Owner Author

egeakman commented May 8, 2024 •
edited
Loading

About the bad cameras: I think the problem is the combination of both too many calls and the camera's bad shutter speed. So even if the camera is 30 fps you have to set a very low exposure to work correctly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Lib+CLI] On Demand Feature + New Class Structure egeakman/mjpeg-streamer
1 participant
@egeakman