-
Notifications
You must be signed in to change notification settings - Fork 2
General Notes
Ethan Kramer edited this page Dec 20, 2018
·
1 revision
- Run code on EC2?
- In a Docker container with Node 10?
- What categories to run audit on?
- What constitutes a failed check?
- What specific task in what category will cause a fail?
- Or Will any failing task in any category cause a fail?
- Or Will any failing task in a specific category cause a fail?
- Or Will all failing tasks in a category only cause a fail?
- Github bot
- Runs on PR (https://developer.github.com/v3/activity/events/types/#pullrequestevent) for the categories marked in settings
- Only causes a fail when the conditions specified for a fail in settings are met
- Adds a comment to the PR with a summary of the results and includes a link to the full results
- Probably outputted as a PDF hosted on S3 or something
- Slack bot
- Only comments in a specified channel when the check fails
- Should we add an option to comment in the channel when the build succeeds?
- Will use the same text as the Github PR content