Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add back meta image #1621

Closed
amyrlam opened this issue Dec 21, 2020 · 2 comments · Fixed by #1647
Closed

Add back meta image #1621

amyrlam opened this issue Dec 21, 2020 · 2 comments · Fixed by #1647
Assignees
@nickschot @mansona
Labels
bug help wanted Extra attention is needed

Comments

@amyrlam
Copy link
Member

amyrlam commented Dec 21, 2020 •
edited by ijlee2
Loading

We've lost the meta image for guides links, e.g. https://twitter.com/Steady5063/status/1340297223733735426

screenshot

Relates to / probably same fix as: ember-learn/ember-blog#854
@ijlee2 ijlee2 added bug help wanted Extra attention is needed labels Mar 20, 2021
@ijlee2
Copy link
Member

ijlee2 commented Mar 20, 2021

@nickschot @mansona Can you have a look at this issue? I checked that e logo does not show up still.

amyrlam added a commit that referenced this issue Mar 20, 2021
@amyrlam
Fix meta image
bfde624 
Resolves: #1621

Related to: ember-learn/ember-website#804
@amyrlam amyrlam mentioned this issue Mar 20, 2021
Merged
@amyrlam
Copy link
Member Author

amyrlam commented Mar 20, 2021

Ah thanks for the reminder. I added it to ember-website with ember-learn/ember-website#804, by hardcoding the path...because I noticed the emberjs and embertimes Twitter accounts sending out links with a blank image.

I made a similar change here: #1647 and will tag you 3 on that PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nickschot nickschot

@mansona mansona

Labels
bug help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix meta image ember-learn/guides-source
4 participants
@nickschot @mansona @amyrlam @ijlee2