Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API changes to astroquery ring node queries will break rings modules #53

Open
emolter opened this issue Dec 21, 2023 · 1 comment
Open
Assignees
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@emolter
Copy link
Owner

emolter commented Dec 21, 2023

Problem

RingNode class was changed to RMSNode in astroquery as of Dec 15 2023. Therefore, any version of astroquery > 0.4.7.dev9008 will fail. see this page

Solution

Two-stage solution. For now, simply pin the dependencies for astroquery to be <= that dev version. Then, once astroquery does the 0.4.7 release, pin astroquery>=0.4.7

@emolter emolter self-assigned this Dec 21, 2023
emolter added a commit that referenced this issue Dec 21, 2023
@emolter emolter added the bug Something isn't working label Feb 15, 2024
emolter added a commit that referenced this issue Mar 14, 2024
attempted solve #61, intermediate fix to #53
@emolter
Copy link
Owner Author

emolter commented Mar 14, 2024

astroquery 0.4.7 has now been released, so the second part of this issue can be worked on now. Just need to rename all the imports according to what's currently in astroquery, then change the astroquery pins in pyproject.toml, requirements.txt, and docs/requirements.txt. Marking this as a good first issue

@emolter emolter added the good first issue Good for newcomers label Mar 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant