Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show archived icon in envelope dropdown for transactions #1034

Open
morremeyer opened this issue Aug 10, 2023 · 3 comments
Open

Show archived icon in envelope dropdown for transactions #1034

morremeyer opened this issue Aug 10, 2023 · 3 comments
Labels
enhancement New feature or improvements to an existing one

Comments

@morremeyer
Copy link
Member

Is your feature request related to a problem? Please describe.
When importing or creating transactions, it is possible that the proposed envelope is archived. This is currently not shown in the dropdown with the envelope pre-selected.

Describe the solution you'd like
The archive icon should be shown in the drop down when the envelope is archived

@morremeyer morremeyer added the enhancement New feature or improvements to an existing one label Aug 10, 2023
@malfynnction
Copy link
Contributor

@morremeyer Should we even suggest envelopes that are archived in those lists?

@morremeyer
Copy link
Member Author

I thought about that, and I'm not yet 100% sure that we shouldn't. When importing past transactions, this might be needed.

In any case, this change will ensure that an archived envelope is always shown as such - if we later change that in the backend later, the code should still work fine.

@malfynnction
Copy link
Contributor

Makes sense!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or improvements to an existing one
Projects
None yet
Development

No branches or pull requests

2 participants