Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup script doesn't work on Mac - command not found: dotnet-episerver #825

Open
gcichosz opened this issue Jun 13, 2022 · 2 comments
Open

Comments

@gcichosz
Copy link

Describe the bug
Running setup.sh script doesn't fully work on a Mac with no prior Optimizely installations. It fails on dotnet-episerver tool, as the tool cannot be found. Running the tool as dotnet episerver instead resolves the issue. In my opinion running dotnet episerver is a bit more universal, as we don't care whether that specific tool is in the $PATH variable or not.
Disclaimer: I'm no .NET Core expert, so this bug might originate from my ignorance

To Reproduce
Steps to reproduce the behavior:

  1. git clone https://github.com/episerver/Foundation.git
  2. cd Foundation
  3. git checkout main
  4. chmod u+x setup.sh
  5. ./setup.sh

Expected behavior
The setup script should run to completion successfully

Desktop (please complete the following information):

  • OS: macOS Monterey 12.4
  • Shell: Z

I'd be happy to create a PR for this bug, if you think both this bug, and the proposed solution make sense.

@clairan
Copy link

clairan commented Jun 17, 2022

I was struggling with the same more than once. Using bash instead of Zsh made it. Not a good solution, but nevertheless a solution.

@daniel-isaacs
Copy link
Collaborator

Looks like this might tie in to this old path issue with dotnet and zsh --
dotnet/sdk#9415
dotnet/sdk#10986

I don't see an issue with the approach above (using dotnet episerver instead of dotnet-episerver in the script) -- both commands seem to run the same in Linux. If I read it correctly, this thread also implies dash vs space is somewhat interchangeable: dotnet/docs#29676

@lunchin, any concerns?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants