Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use explicit namespacing in reports #91

Open
jamesmbaazam opened this issue May 25, 2023 · 3 comments
Open

Use explicit namespacing in reports #91

jamesmbaazam opened this issue May 25, 2023 · 3 comments
Assignees
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@jamesmbaazam
Copy link
Member

As the purpose of this package is to illustrate useful pipelines (and packages) for achieving end-to-end tasks, I wonder if it might not be better to use explicit namespacing (i.e., package::some_function()) so the user knows exactly where the functions are coming from.

@Bisaloo
Copy link
Member

Bisaloo commented May 25, 2023

Yes, that may be a good idea from a teaching perspective. Let's loop @avallecam in before jumping right in but I'd be open to a PR for this.

@avallecam
Copy link
Member

I totally agree, this is sth that I can also consider doing at the beginning of any material.

@Bisaloo Bisaloo added good first issue Good for newcomers help wanted Extra attention is needed and removed discussion labels May 25, 2023
@jamesmbaazam
Copy link
Member Author

I'm happy to submit a PR later next week. I was planning to review episoap next week, so I'll add it to the list of to-dos.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants