Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nicer representation of titles with non-ASCII in the path #1

Open
Cook879 opened this issue Aug 23, 2023 · 1 comment
Open

Nicer representation of titles with non-ASCII in the path #1

Cook879 opened this issue Aug 23, 2023 · 1 comment

Comments

@Cook879
Copy link

Cook879 commented Aug 23, 2023

Currently words like café look incomplete, as in the path that becomes caf.

Text::Unidecode takes the non-ASCII characters and finds the equivalent, so café will become cafe.

Also works for other characters sets (Greek, Russian, Chinese, etc). Right now a title of 北亰 results in no path being generated, with this change the path is bei-jing.
Cook879 pushed a commit that referenced this issue Aug 23, 2023
#1 Nicer representation of titles with non-ASCII in the path
847a735
@Cook879
Copy link
Author

Cook879 commented Aug 23, 2023

Changes are in 847a735

Mostly tested code in a different context (I have a copy of the method from here), however I did install easy_pages and do some tests which seem fine

fatchild added a commit that referenced this issue Nov 30, 2023
@fatchild
Merge pull request #2 from eprints/unidecode
8af2e18 
#1 Nicer representation of titles with non-ASCII in the path
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Cook879