Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plot viewer: x-axis range is wrongly extended to the past #376

Open
hnformentin opened this issue Aug 18, 2022 · 7 comments
Open

Plot viewer: x-axis range is wrongly extended to the past #376

hnformentin opened this issue Aug 18, 2022 · 7 comments
Labels
bug Something isn't working

Comments

@hnformentin
Copy link
Contributor

Describe the bug
In the plot viewer of webviz-ert, the range of x-axis is extended back when plotting the pred_ref case. We compared to ert gui and this behavior is not present there (see images).

To Reproduce
Steps to reproduce the behavior:

  1. Get a copy of the data set of Drogon tutorial (tar xhf /scratch/fmu/share/drogon/course/drogon_current.tar.gz)
  2. source /prog/res/komodo/stable/enable
  3. cd drogon_20211115_12-12/resmod/ff/21.0.1/ert/model
  4. ert gui drogon_ahm.ert
  5. Select data as indicated in the image

Expected behavior
The x-axis should not be displaced to an early date because the case pred_ref is loaded.

Screenshots
Webviz-ert compared to ert gui:

Screenshot from 2022-08-18 14-38-46

Screenshot from 2022-08-18 14-34-26

@hnformentin hnformentin changed the title Plot viewer: Plot viewer: x-axis range is wrongly extended to the past Aug 18, 2022
@hnformentin
Copy link
Contributor Author

By the way, why the color of the observations is different?

@valentin-krasontovitsch
Copy link
Contributor

By the way, why the color of the observations is different?

you mean black in the ert gui, and red in webviz-ert?

@hnformentin
Copy link
Contributor Author

By the way, why the color of the observations is different?

you mean black in the ert gui, and red in webviz-ert?

Yes...

@valentin-krasontovitsch
Copy link
Contributor

that's a good question 😅

@hnformentin
Copy link
Contributor Author

I noticed the difference, because red–green color blindness is the most common form, so I would avoid having both in the same plot...

@valentin-krasontovitsch
Copy link
Contributor

it's a good point! i know way too little about barrier-free design (is that the right term?), and also think about it too litte.

@andreas-el andreas-el self-assigned this Oct 5, 2022
@andreas-el
Copy link

The issue seems to be caused by a negative value (-1) present in the timestamp series. This is plotted differently in webviz and the gui plotter, where webviz allows this as a valid datapoint and the gui plotter omits drawing it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Backlog
Development

No branches or pull requests

4 participants