Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prop-types #31

Open
benmccann opened this issue Jun 25, 2024 · 2 comments
Open

prop-types #31

benmccann opened this issue Jun 25, 2024 · 2 comments

Comments

@benmccann
Copy link
Contributor

See https://stackoverflow.com/questions/73954484/should-i-use-the-package-prop-types-or-pass-a-props-interface-to-react-component

Should it be applied conditionally only to Typescript projects though? That might require some new functionality in the plugin

@43081j
Copy link
Contributor

43081j commented Jun 25, 2024

i wonder if it sits better with one of the react specific eslint plugins (e.g. one of the alternatives to eslint-plugin-react we probably list here)

since the rule could then be "if in typescript, assert that an interface is used, otherwise, assert prop-types is used" etc

@benmccann
Copy link
Contributor Author

Filed issues there to see what the maintainers of those libraries think about the idea:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants