From da0eb2e0da3e23e1693d7d3a1872ad453eb991dd Mon Sep 17 00:00:00 2001
From: Mikhail Uvarov <arcusfelis@gmail.com>
Date: Wed, 6 Mar 2024 11:45:23 +0100
Subject: [PATCH] Improve coverage for disco

---
 test/cets_SUITE.erl | 22 ++++++++++++++++++++++
 1 file changed, 22 insertions(+)

diff --git a/test/cets_SUITE.erl b/test/cets_SUITE.erl
index ee4cef73..f51e75bc 100644
--- a/test/cets_SUITE.erl
+++ b/test/cets_SUITE.erl
@@ -153,8 +153,10 @@ cases() ->
         unknown_message_is_ignored_in_ack_process,
         unknown_cast_message_is_ignored_in_ack_process,
         unknown_call_returns_error_from_ack_process,
+        unknown_message_is_ignored_in_disco_process,
         code_change_returns_ok,
         code_change_returns_ok_for_ack,
+        code_change_returns_ok_for_disco,
         run_spawn_forwards_errors,
         run_tracked_failed,
         run_tracked_logged,
@@ -2341,6 +2343,11 @@ unknown_message_is_ignored_in_ack_process(Config) ->
     AckPid ! oops,
     still_works(Pid).
 
+unknown_message_is_ignored_in_disco_process(_Config) ->
+    Pid = start_simple_disco(),
+    Pid ! oops,
+    #{} = sys:get_state(Pid).
+
 unknown_cast_message_is_ignored_in_ack_process(Config) ->
     {ok, Pid} = start_local(make_name(Config)),
     #{ack_pid := AckPid} = cets:info(Pid),
@@ -2366,6 +2373,12 @@ code_change_returns_ok_for_ack(Config) ->
     ok = sys:change_code(AckPid, cets_ack, v2, []),
     sys:resume(AckPid).
 
+code_change_returns_ok_for_disco(_Config) ->
+    Pid = start_simple_disco(),
+    sys:suspend(Pid),
+    ok = sys:change_code(Pid, cets_ack, v2, []),
+    sys:resume(Pid).
+
 run_spawn_forwards_errors(_Config) ->
     ?assertException(
         error,
@@ -2960,6 +2973,15 @@ start_disco(Node, Opts) ->
     schedule_cleanup(Pid),
     Pid.
 
+start_simple_disco() ->
+    F = fun(State) ->
+        {{ok, []}, State}
+    end,
+    {ok, Pid} = cets_discovery:start_link(#{
+        backend_module => cets_discovery_fun, get_nodes_fn => F
+    }),
+    Pid.
+
 wait_for_name_to_be_free(Node, Name) ->
     %% Wait for the old process to be killed by the cleaner in schedule_cleanup.
     %% Cleaner is fast, but not instant.