Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

summons command does not validate to summon for a valid review #15

Open
shivamb opened this issue Jan 18, 2016 · 2 comments
Open

summons command does not validate to summon for a valid review #15

shivamb opened this issue Jan 18, 2016 · 2 comments

Comments

@shivamb
Copy link

shivamb commented Jan 18, 2016

While summoning a reviewer to review for a task it does not pre-check if the reviewer has already reviewed a revision. In either cases if the reviewer has already accepted the revision, rejected or asked for a change the summon command summons the user.

@etcinit
Copy link
Owner

etcinit commented Jan 20, 2016

Yes, the current functionality of the summon command is very basic. Future versions should consider this and some sort of Slack-to-Phabricator user mapping.

@etcinit
Copy link
Owner

etcinit commented Oct 17, 2016

I've begun work on this area. Currently, it seems Phabricator does not return individual reviewer status when querying for revisions. However, it does include the status of the revisions in general (Open, Closed, etc).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants