Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Benchmark diff calculation broken in c_ext_benchmarks #15138

Open
cameel opened this issue May 23, 2024 · 1 comment
Open

Benchmark diff calculation broken in c_ext_benchmarks #15138

cameel opened this issue May 23, 2024 · 1 comment
Labels
bug 🐛 low effort There is not much implementation work to be done. The task is very easy or tiny. low impact Changes are not very noticeable or potential benefits are limited. nice to have We don’t see a good reason not to have it but won’t go out of our way to implement it. testing 🔨

Comments

@cameel
Copy link
Member

cameel commented May 23, 2024

The c_ext_benchmarks job in CI is supposed to calculate a diff between its current one and the one on the base branch and attach the result as an artifact. This does not happen for some reason. If you look at any of the recent runs on pull requests (e.g. c_ext_benchmarks artifacts in job e34192) you'll notice that it properly obtains the files to be diffed, but does not actually create the diff.
@cameel cameel added bug 🐛 testing 🔨 low effort There is not much implementation work to be done. The task is very easy or tiny. low impact Changes are not very noticeable or potential benefits are limited. nice to have We don’t see a good reason not to have it but won’t go out of our way to implement it. labels May 23, 2024
@cameel
Copy link
Member Author

cameel commented May 23, 2024

This actually broke quite a while ago, but never seemed important enough to spend time fixing. The fix is probably trivial though. I'm submitting an issue so that I don't have to explain it again every time. Also maybe we'll finally fix it during this bugfixing sprint :)

@cameel cameel mentioned this issue May 28, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug 🐛 low effort There is not much implementation work to be done. The task is very easy or tiny. low impact Changes are not very noticeable or potential benefits are limited. nice to have We don’t see a good reason not to have it but won’t go out of our way to implement it. testing 🔨
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@cameel