Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Every single one of the "built on ETH" SVG graphics were not expanded properly #512

Open
zagarskas opened this issue May 9, 2021 · 1 comment

Comments

@zagarskas
Copy link

zagarskas commented May 9, 2021

Problem is here:
https://github.com/ethhub-io/ethhub/tree/master/docs/assets/files/builtoneth_branding/SVG
Simply view any of those files in a browser (or attempt to use them in a project) and the problem will be obvious

Every SVG here was exported with text that was not expanded.
The fix is simple: expand the text in illustrator, then export it

Currently, the fix is to open them each, one at a time, read the error, download the font, edit them, resize the text, expand the text, then save them.
This is not a complaint, this is a request from someone who wants to use the correct branding elements the exact way the original designer intended them to be used.

image
image
image
image

While I was fixing these I also noticed that some of these SVG files have ALL of the other files IN them.
Take a look:
not a sane way to handle SVG elements. (No need to have 10x layers here, bloats file size)
image

@zagarskas
Copy link
Author

zagarskas commented May 9, 2021

Since I have short deadline I had to fix all of these, so here they are attached.

Note - had to head to "object, expand" twice on the Ethereum wordmark, then merge it as a simple shape.
(seems like there are 2 layers of fonts, one light and one heavy on top of eachother, those have been made sane as well)

These now display properly in the browser and open without issue nor do they require users to get the font.

Now, these are all nice and clean tight small vectors with no fonts and no layers...
image

Compare these to the official repository on Mac, PC, Chrome, Firefox, Android, Ios, ect...
Unfortunately I was not able to upload SVG files in this comment (not sure if you can enable that)

Builtonethereum-fixed.zip

*cheers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant