_safe_join fails when models have special characters in db_table

[rouse-billy-herren]

Summary

Calls to _safe_join() fail when used on a model with a Meta.db_table value that contains characters that are not valid in a python identifier.

Scenario

When using Postgres as a database back end, it's not uncommon to use schema_name"."table_name when defining model db_table values to take advantage of Postgres schema features.

Models using this method cause an error when generating a temporary annotation name in _safe_join().

Suggested Solution

I believe normalizing the db_table name, and using a static prefix to avoid conflicts, should resolve the issue.

I can put together a PR to address this - is it something you would consider merging?

[way-dave]

Absolutely! Please hit me up!

Sorry for the delay, I've been a bit busy :)

[etianen]

Whoops, wrong account!

…

On Thu, 7 Jul 2022 at 17:49, Dave Hall ***@***.***> wrote: Absolutely! Please hit me up! Sorry for the delay, I've been a bit busy :) — Reply to this email directly, view it on GitHub <#913 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AABEKCBEXGXGUZ3KCGVYTXLVS4DAJANCNFSM5Z7CNNDA> . You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>