Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Layout #5

Open
facuxpalacio opened this issue Jun 28, 2021 · 5 comments
Open

Layout #5

facuxpalacio opened this issue Jun 28, 2021 · 5 comments

Comments

@facuxpalacio
Copy link
Owner

Hey!

I was wondering if it would be better to use a dashboard instead of tabsets. This would occupy a lateral section of the page, but the general layout is much more aesthetic.

See how dashboards look:

https://rstudio.github.io/shinydashboard/

Have a good week!

Facu

@emmajhudgins
Copy link
Collaborator

I think it definitely has a better UX/UI - is there a big overhead in converting the code to be usable in shinydashboard? If not I think we should go for it.

@facuxpalacio
Copy link
Owner Author

Thanks Emma. From what I've seen, it seems not be a big headache. Let's see how it results...

Have a good weekend!

@facuxpalacio
Copy link
Owner Author

I finally moved our script to shinydashboard. It looks just amazing! I thought it was gonna be harder, but it was quite simple indeed, as the hierarchy of functions is very similar in both layouts.

I turned off your report section just to be sure that the main body worked. I'll continue tomorrow, there's still a lot of work to do.

Facu

@emmajhudgins
Copy link
Collaborator

It looks SO GOOD! It's noticeably slower to load on my computer, but hopefully won't be too slow on their servers.

And agreed there's lots to do. I've set aside time this week to finish my portions - sorry for the delay!

@facuxpalacio
Copy link
Owner Author

Yeaahhh, I'm so in love with this haha.

After moving the script to shinydashboards, I noticed that the chunk on the report threw the following error:

"Error in tagAssert(header, type = "header", class = "main-header") : Expected tag to be of type header"

It seems to be a minor issue, but haven't delved into this. Could you take a look? Remember there's no rush Emma.

emmajhudgins added a commit that referenced this issue Jul 9, 2021
…form data in the right format, saving first plot
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants