Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: bare 'edit review' URL shows a map with default coordinates #417

Open
wbazant opened this issue Jul 5, 2024 · 0 comments · May be fixed by #419
Open

bug: bare 'edit review' URL shows a map with default coordinates #417

wbazant opened this issue Jul 5, 2024 · 0 comments · May be fixed by #419
Labels
bug Unexpected problems or unintended behavior

Comments

@wbazant
Copy link
Contributor

wbazant commented Jul 5, 2024

Constructing a URL like https://beta.fallingfruit.org/reviews/66067/edit takes a user to the default location, but we should be showing the location which is being reviewed.

This is a bug of very low severity since it does not happen during normal navigation - the only way to go to an edit review page is from a location page, where we do correctly show a map.

I just changed some related stuff and noticed that it happens so I fixed it (very easily with AI). The proposed resolution is to recognize that the situation is happening in ConnectReview, fetch the review's location, then set the position.

@wbazant wbazant linked a pull request Jul 6, 2024 that will close this issue
@ezwelty ezwelty added the bug Unexpected problems or unintended behavior label Jul 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Unexpected problems or unintended behavior
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants