Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prevent installation into project folder itself #8

Open
jakoch opened this issue Jan 7, 2016 · 1 comment
Open

prevent installation into project folder itself #8

jakoch opened this issue Jan 7, 2016 · 1 comment

Comments

@jakoch
Copy link

jakoch commented Jan 7, 2016

Hey Steve,

when a user uses "webroot-dir": "./" the project folder gets overwritten.
I'm reporting this, because of a StackOverflow question.
It could be useful to add a notice to the readme to document that behavior
or prevent the installation into the project folder.

Regards, Jens

@sbuzonas
Copy link
Member

Thanks for the feedback, I knew of that but haven't decided how to address it yet. I suppose documentation for now at the very least.

I should bail if something doesn't seem right, but I was thinking it may be helpful to use the Filesystem utility in LibraryInstaller or DownloadManager to warn and confirm when the target directory is not empty.

sbuzonas added a commit that referenced this issue Mar 23, 2016
Notify users about directory collisions because of #8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants