Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't parse mxm - just request lrc! #11

Open
mrsobakin opened this issue Jan 29, 2023 · 0 comments
Open

Don't parse mxm - just request lrc! #11

mrsobakin opened this issue Jan 29, 2023 · 0 comments

Comments

@mrsobakin
Copy link

@fashni
This is a simple trick I discovered while writing a bash script to fetch synced lyrics. I was reverse engineering musixmatch's API and found the same URL you did (mxlrc.py / line 17). And, of course, I was not satisfied with the cryptic mxm lyrics format that it returned. But this is where our solutions diverge. You wrote a whole mxm parser, and I... Well, I just YOLO'd it and replaced subtitle_format=mxm with subtitle_format=lrc. And to my surprise it worked.

It's nice to have your parser, just in case musixmatch will decide to remove lrc support. But if your goal is to make a lyrics fetcher - just change the subtitle_format, and the code will become 10x smaller and simpler.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant