Skip to content
This repository has been archived by the owner on Jul 18, 2022. It is now read-only.

Contribute new comment styles #22

Open
6 of 13 tasks
fbiville opened this issue Dec 11, 2018 · 1 comment · Fixed by #53
Open
6 of 13 tasks

Contribute new comment styles #22

fbiville opened this issue Dec 11, 2018 · 1 comment · Fixed by #53
Labels
good first issue Good for newcomers
Milestone
1.0.0-M05

Comments

@fbiville
Copy link
Owner

fbiville commented Dec 11, 2018 •
edited
Loading

Preferably done after #24.

  • (d5e361c) SlashStarStar /** [...] */
  • (c810dac) Hash #
  • (476353c) Rem REM
  • DashDash --
  • SemiColon ;
  • BraceDash {- [...] -}
  • (72519da) XML <!-- [...] --> (better name welcome)
  • ParenStar (* *) (AppleScript, some versions of Pascal)
  • BraceStar {* *} (Pascal)
  • SingleQuote ' (some Basics)
  • Exclamation !
  • ColdFusion <!--- [...] ---> (better name welcome)
  • Percent %
@fbiville fbiville added this to the 0.1.0 milestone Dec 11, 2018
@fbiville
Copy link
Owner Author

There should be at least 1 integration test per introduced style.

@fbiville fbiville added the good first issue Good for newcomers label Dec 11, 2018
@fbiville fbiville modified the milestones: 1.0.0-M01, 1.0.0-M02 Dec 28, 2018
fbiville pushed a commit that referenced this issue Jan 29, 2019
@dialaya
[#22] Add dash comment style
5bf8029
fbiville pushed a commit that referenced this issue Feb 1, 2019
@dialaya
[#22] Add Dash comment style
b109a1d
fbiville pushed a commit that referenced this issue Feb 1, 2019
@dialaya
[#22] Add Dash comment style
c810dac
@redpanda redpanda mentioned this issue May 28, 2019
Merged
2 tasks
@fbiville fbiville reopened this May 29, 2019
fbiville pushed a commit that referenced this issue Jun 15, 2019
@Psycokwet @fbiville
[#22] Add REM comment style
18222b1
fbiville pushed a commit that referenced this issue Jun 24, 2019
@Psycokwet
[#22] Add REM comment style
476353c
fbiville pushed a commit that referenced this issue Jul 30, 2019
@AElMehdi
[#22] Contribute SlashStarStar
522d75e
fbiville pushed a commit that referenced this issue Aug 1, 2019
@AElMehdi
[#22] Contribute SlashStarStar
d5e361c
@fbiville fbiville modified the milestones: 1.0.0-M04, 1.0.0-M05 Dec 31, 2019
@adrienjoly adrienjoly mentioned this issue Apr 28, 2020
Closed
fbiville pushed a commit that referenced this issue May 1, 2020
@adrienjoly @fbiville
Introduce XML comment style
8a44e04 
Contributes to #22

Note this fixes unnecessary escaping when applying the license
template as `headache` relied until now on `html/template` instead
of `text/template`. This prevented the XML comment style to be
properly applied.
fbiville pushed a commit that referenced this issue May 1, 2020
@adrienjoly @fbiville
[#22] Introduce XML comment style
72519da 
Note this fixes unnecessary escaping when applying the license
template as `headache` relied until now on `html/template` instead
of `text/template`. This prevented the XML comment style to be
properly applied.
amorenojimenez added a commit to amorenojimenez/headache that referenced this issue Jun 30, 2020
@amorenojimenez
[fbiville#22] Introduce SingleQuote comment style
ff7f3aa
fbiville pushed a commit that referenced this issue Jul 28, 2020
@amorenojimenez @fbiville
[#22] Introduce SingleQuote comment style
85860a8
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
1.0.0-M05
Development

Successfully merging a pull request may close this issue.

Implemented new comment styles redpanda/headache
1 participant
@fbiville