You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The closeButtonClickHandler calls exitFullScreen() even if the document was in fullscreen mode before baguette box was opened, and even if options.fullScreen is false.
This breaks websites & apps handling their own fullscreen mode:
When the website/app is in fullscreen mode, opening and then closing a baguetteBox will make the entire app exit fullscreen. This is breaking UX badly.
Options:
At least check options.fullScreen (like before calling enterFullScreen()) and do notexitFullScreen() if options.fullScreen is false.
Track the fullScreen state in showOverlay() and only exit fullScreen if the document was not already in fullScreen mode during showOverlay().
You can apply fullScreen to the baguetteBox root element instead of the entire document.
If document.fullscreenElement is already not null, then do not go fullscreen at all.
Also, do not exit fullscreen if document.fullscreenElement is not the baguetteBox element.
The text was updated successfully, but these errors were encountered:
LeoniePhiline
changed the title
BaguetteBox must not exist fullscreen if it did not go fullsreen itself.
BaguetteBox must not exist fullscreen if it did not enter fullsreen itself.
Aug 20, 2019
LeoniePhiline
changed the title
BaguetteBox must not exist fullscreen if it did not enter fullsreen itself.
BaguetteBox must not exist fullscreen if it did not enter fullscreen itself.
Aug 20, 2019
LeoniePhiline
changed the title
BaguetteBox must not exist fullscreen if it did not enter fullscreen itself.
BaguetteBox must not exit fullscreen if it did not enter fullscreen itself.
Aug 20, 2019
The
closeButtonClickHandler
callsexitFullScreen()
even if the document was in fullscreen mode before baguette box was opened, and even ifoptions.fullScreen
isfalse
.This breaks websites & apps handling their own fullscreen mode:
When the website/app is in fullscreen mode, opening and then closing a baguetteBox will make the entire app exit fullscreen. This is breaking UX badly.
Options:
At least check
options.fullScreen
(like before callingenterFullScreen()
) and do notexitFullScreen()
ifoptions.fullScreen
is false.Track the fullScreen state in
showOverlay()
and only exit fullScreen if the document was not already in fullScreen mode duringshowOverlay()
.Ideally replace
document.fullscreen
.document.fullscreenElement
is already notnull
, then do not go fullscreen at all.document.fullscreenElement
is not the baguetteBox element.The text was updated successfully, but these errors were encountered: