We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
I think pencil, as a library shouldn't use unwrap unless it's extremely sure that the error can't happen.
app.run(binding.as_str()); can easily fail to bind to a port. It should return a Result. I can easily make it panic.
app.run(binding.as_str());
Result
Is the error handling story still under design? Do you accept PRs that (partially) refactor the error handling?
The text was updated successfully, but these errors were encountered:
No branches or pull requests
I think pencil, as a library shouldn't use unwrap unless it's extremely sure that the error can't happen.
app.run(binding.as_str());can easily fail to bind to a port. It should return aResult. I can easily make it panic.Is the error handling story still under design? Do you accept PRs that (partially) refactor the error handling?
The text was updated successfully, but these errors were encountered: