Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Last bin in light curves overlaps the next-to-the-last bin in time #64

Open
jasercion opened this issue Mar 20, 2020 · 1 comment
Open

Comments

@jasercion
Copy link
Contributor

Ported from jira STGEN-107.

Hi,
I have found a bug in the evtbin package. When producing a light curve
using gtbin, the last bin in the output FITS file starts before the
end of the previous bin, in other words TIME of the last bin is less
than (TIME+TIMEDEL) of the previous one. See for example the attached
light curve "prova.lc". These are the last three rows:

Row TIME TIMEDEL
(TIME+TIMEDEL)
10823 241779317.787482 0.0300000011920929 (241779317.81748200119)
10824 241779317.817482 0.0300000011920929 (241779317.84748200119)
10825 241779317.837992 0.0110200047492981

I attach also the parameters file used to produce "prova.lc", and the
events file (a GBM Time-Tagged-Event file).
I don't know if this problem with the binner (i think) impacts only
the last bin of the light curves (that should not be a big issue), or
other things as well.

I have used one of the last SCons version available (contained in
ScienceTools-LATEST-1-3154), as well as other older version, and the
problem shows out in every version.

@jasercion
Copy link
Contributor Author

Response from @joeastro:

I've retested for this issue by following the "LAT Aperture Photometry" analysis thread, and I confirm that it is still present. It seems that for N time bins, the TIMEDEL of the last bin is actually twice the difference in time between the last and second-last bins. For the other bins, the TIMEDEL keyword accurately reflects the difference in time between adjacent bins. I will need to look at the LIN algorithm that GTBIN uses to figure out how it is treating the last bin.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant