Correction of a problem where export to dotenv fails if the config value is operated with empty characters in the 1st gen of functions. #7368
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colerogers
reviewed
Jul 18, 2024
| @@ -178,7 +178,7 @@ const CHARACTERS_TO_ESCAPE_SEQUENCES: Record<string, string> = { | |||
|
|
|||
| function escape(s: string): string { | |||
| // Escape newlines, tabs, backslashes and quotes | |||
| return s.replace(/[\n\r\t\v\\"']/g, (ch) => CHARACTERS_TO_ESCAPE_SEQUENCES[ch]); | |||
| return (s || '').replace(/[\n\r\t\v\\"']/g, (ch) => CHARACTERS_TO_ESCAPE_SEQUENCES[ch]); | |||
There was a problem hiding this comment.
So the issue is that s is coming into this function as undefined from the env map. Let's change where this is actually being called below.
| @@ -178,7 +178,7 @@ const CHARACTERS_TO_ESCAPE_SEQUENCES: Record<string, string> = { | |||
|
|
|||
| function escape(s: string): string { | |||
| // Escape newlines, tabs, backslashes and quotes | |||
| return s.replace(/[\n\r\t\v\\"']/g, (ch) => CHARACTERS_TO_ESCAPE_SEQUENCES[ch]); | |||
| return (s || '').replace(/[\n\r\t\v\\"']/g, (ch) => CHARACTERS_TO_ESCAPE_SEQUENCES[ch]); | |||
| } | |||
|
|
|||
| /** | |||
There was a problem hiding this comment.
On line 188, let's change it to something like
const lines = envs.map(({ newKey, value }) => `${newKey}="${value === undefined ? "" : escape(value)}"`);
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Correction of a problem where export to dotenv fails if the config value is operated with empty characters in the 1st gen of functions.
Scenarios Tested
Sample Commands