Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Efficiency TODO in endpoint.rs #4599

Merged
merged 2 commits into from
May 8, 2024
Merged

Efficiency TODO in endpoint.rs #4599

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0b56aca
Improve efficiency of endpoint for loop
andr3wy May 7, 2024
d6bfdb7
Merge branch 'main' into 3273
roypat May 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions src/vmm/src/dumbo/tcp/endpoint.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -223,10 +223,7 @@ impl Endpoint {
// We have to remove the bytes up to end from receive_buf, by shifting the
// others to the beginning of the buffer, and updating receive_buf_left.
// Also, advance the rwnd edge of the inner connection.
// TODO: Maximum efficiency.
for j in 0..b.len() - end {
b[j] = b[j + end];
}
b.copy_within(end.., 0);
self.receive_buf_left -= end;
// Safe to unwrap because we assert that the response buffer is small
// enough.
Expand Down
Loading