-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Javascript version #1
Comments
Nice! Good work.! Thanks for letting me know. |
No problem, although I've noticed that some tunes are sounding strange so it might be buggy. Can you paste translated versions of
so I can compare output from XLSM? |
Your tempo does not seem right... import music import music |
GetNoteDurationFromRTTTL("G", "4", "125") returns 16 and your outputs suggest it should be 8. I can't see why it should be 8 as
suggest that 4 (second parameter to GetNoteDurationFromRTTTL()) maps to 16. |
Is content of durationMap correct? |
Sorry for my late answer... If it still useful, what the VBA code has is actually:
|
And it seems that it also needs Since you do not seem to take into account the bpm of the original rtttl |
CircuitPlaygroundExpress version of your code as a custom block: |
Hi,
I've used your code for js version.
At https://makecode.microbit.org/_9LphJJhvV7mz if you want to check/make improvements.
The text was updated successfully, but these errors were encountered: