Good conductor draft (just for discussion) #1782
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is a draft on SIBC just to give more context on #1773 and hopefully be helpful in making decisions on how to structure the code. In this draft, I just added it in a separate file for now, to avoid massive difference in the code. One plan later is to split Medium.py.
As you can see,
SubpixelSpec
now has four fields: dielectric, metal, PEC, and lossy_metal. When lossy_metal takes SIBC, solver will apply SIBC to structures made oftd.LossyMetal
. We don't validate if the metal is lossy enough, as it heavily depends on the geometries.Example
And the result:
The fitting is applied to the medium
frequency_range
. So thefrequency_range
must not be None, and it must be finite and positive.