Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make cache lifetime for resources configurable #32

Open
robertlemke opened this issue May 5, 2022 · 0 comments
Open

Make cache lifetime for resources configurable #32

robertlemke opened this issue May 5, 2022 · 0 comments
Labels
enhancement

Comments

@robertlemke
Copy link
Member

Currently, the cache-control header is not configured consequently in all cases for Google Cloud Storage resources, which leads to published resourced getting a default expires header with 3600 seconds. That cache lifetime is too short and is disadvantageous in speed reports.

A plugin user should be able to configure a cache lifetime (for example 1 year) which is considered in all relevant situations where resources are imported, uploaded or updated, so that a proper cache-control header exists for each storage entry.

Furthermore it may be necessary to provide a way to update metadata for existing resources.
@robertlemke robertlemke mentioned this issue May 5, 2022
Open
robertlemke added a commit to flownative/docker-nginx that referenced this issue May 5, 2022
@robertlemke
Set Cache-Control header for proxied GCS resources
099f04c 
The "expires" statement does not seem to have an effect – the lifetime
provided by Google always won. However, providing Cache-Control might
work and solve as a hotfix for flownative/flow-google-cloudstorage#32

#7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@robertlemke