Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert loading order of environment files #80

Open
kdambekalns opened this issue Jun 26, 2024 · 0 comments
Open

Revert loading order of environment files #80

kdambekalns opened this issue Jun 26, 2024 · 0 comments
Assignees
@robertlemke @kdambekalns
Labels
dx affects developer experience (experience) enhancement enhances an existing feature or functionality (improvements) idea not an actual task or story yet, but a promising idea (improvements)

Comments

@kdambekalns
Copy link
Member

Due to the order of files in

localbeach/pkg/beachsandbox/helpers.go

Line 56 in 27c1937

envFilenames := []string{".env", ".localbeach.env", ".localbeach.dist.env"}
one cannot override a variable from localbeach.dist.env in one of the other files.

Or I am too stupid to see my error…

Should we revert the order, or was this a very conscious choice?
@kdambekalns kdambekalns added dx affects developer experience (experience) enhancement enhances an existing feature or functionality (improvements) idea not an actual task or story yet, but a promising idea (improvements) labels Jun 26, 2024
@kdambekalns kdambekalns changed the title Revert loading order of evnironment files Revert loading order of environment files Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@robertlemke robertlemke

@kdambekalns kdambekalns

Labels
dx affects developer experience (experience) enhancement enhances an existing feature or functionality (improvements) idea not an actual task or story yet, but a promising idea (improvements)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@robertlemke @kdambekalns