Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to Brave Search bangs database #1

Open
foo-dogsquared opened this issue Apr 24, 2022 · 1 comment
Open

Switch to Brave Search bangs database #1

foo-dogsquared opened this issue Apr 24, 2022 · 1 comment
Labels
enhancement New feature or request

Comments

@foo-dogsquared
Copy link
Owner

Brave Search has a bangs database based from Duckduckgo. Though, it has been updated to have a cleaner scheme and additional metadata including a favicon link which could be used for Pop launcher since it can display them (see updated web plugin for an example of display favicons).

It will break existing changes so this will be set for v2 (if that ever happens). Additionally, Brave Search is in beta (as of 2022-04-24) so this issue will not be revisited for some time (probably). Even though, there's only a couple of users ;p, it's best to assume that in this planet of 10 billion people, somebody out there uses plugin AND uses a customized version of Duckduckgo bangs database (READ: ME!!!!).

These are the changes that will break the plugin that guarantee v2:

  • It has a new query placeholder (e.g., {query} instead of {{{s}}}).
  • Updated schema.
@foo-dogsquared
Copy link
Owner Author

Welp, Brave Search is out of beta and I've used it enough and it seems stable enough so this is a surefire feature to be included in v2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant