Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: saving a file (screenshot, response) in remote worker will not forward to client #403

Open
1 of 5 tasks
ocervell opened this issue May 8, 2024 · 0 comments
Open
1 of 5 tasks
Assignees
Labels
bug Something isn't working important runners

Comments

@ocervell
Copy link
Contributor

ocervell commented May 8, 2024

When running in worker mode with a remote worker, there are a few problems when taking a screenshot with httpx:

  • Screenshot path on client shows remote path (path disclosure / leak)
  • Screenshot / file path is not accessible on client since it's a remote path

We could have the problem for any task saving files in the remote machine. We might need a broader implementation like:

General implem:

  • Task saves remote path
  • Task loads remote path as base64-encoded bytes
  • [client] Client loads remote path locally and saves it to runner output folder.
@ocervell ocervell self-assigned this May 8, 2024
@ocervell ocervell added bug Something isn't working important labels May 8, 2024
@ocervell ocervell changed the title fix: taking a screenshot in worker mode shows remote path fix: saving a file (screenshot, response) in remote worker will not forward output to client May 8, 2024
@ocervell ocervell changed the title fix: saving a file (screenshot, response) in remote worker will not forward output to client fix: saving a file (screenshot, response) in remote worker will not forward to client May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working important runners
Projects
None yet
Development

No branches or pull requests

1 participant