Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inject Django's DEBUG setting into sass namespace as $debug #41

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

nolsto
Copy link
Member

@nolsto nolsto commented Jul 22, 2015

An idea from @rockymeza in #32.

@rockymeza
Copy link

Yay!

A couple quick questions:

  1. Would this be better done as an Extension? (That way we could opt-in/out of it).
  2. Should it be $DEBUG?

Release blocker: no docs.

@rockymeza
Copy link

Also, in the docs, we should probably leave a reminder that it's not a good idea to hide things that you aren't comfortable with people seeing, as that info will still be available in the HTML.

@nolsto
Copy link
Member Author

nolsto commented Jul 23, 2015

Would this be better done as an Extension? (That way we could opt-in/out of it).

Good call. That avoids the kwarg fiddling this relies on now.
Could do

# opt-in option
DjangoScssCompiler() # extensions=(DjangoExtension, CompassExtension)
DjangoScssCompiler(extensions=(DjangoDebugExtension. DjangoExtension, CompassExtension))

# opt-out option
DjangoScssCompiler() # extensions=(DjangoDebugExtension, DjangoExtension, CompassExtension)
DjangoScssCompiler(extensions=(DjangoExtension, CompassExtension))

Not sure as to which would be preferred. Thoughts?

Should it be $DEBUG?

Though it looks less like a typical sass variable, that would certainly make a more explicit connection with the Django setting.

@rockymeza
Copy link

I think opt-in might be better. We've got lots of people already using the system and we don't want to suddenly override their variables in any way.

Though it looks less like a typical sass variable, that would certainly make a more explicit connection with the Django setting.

lowercase then

@gavinwahl
Copy link
Member

Do you guys actually have a use for this?

@rockymeza
Copy link

I don't yet.

-rocky

On Sat, Jul 25, 2015 at 1:01 AM, Gavin Wahl [email protected]
wrote:

Do you guys actually have a use for this?


Reply to this email directly or view it on GitHub
#41 (comment)
.

@rockymeza
Copy link

maybe better as docs?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants