Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Menu tests are failing on some developer computers #4976

Open
2 tasks done
Jacalz opened this issue Jun 25, 2024 · 6 comments
Open
2 tasks done

Menu tests are failing on some developer computers #4976

Jacalz opened this issue Jun 25, 2024 · 6 comments
Labels
bug Something isn't working testing Issues related to tests and testing.

Comments

@Jacalz
Copy link
Member

Jacalz commented Jun 25, 2024

Checklist

  • I have searched the issue tracker for open issues that relate to the same problem, before opening a new one.
  • This issue only relates to a single bug. I will open new issues for any other problems.

Describe the bug

I am getting some strange behaviour where the tests are failing locally on my machine but all of the tests are passing on the CI (yes, the failing tests are being run on CI because -tags ci makes no difference and so on). When I first noticed these issues, I pushed up the modified .png files but that caused the CI to fail. Strange?

How to reproduce

  1. Run the widget tests locally go test ./widget/....
  2. Notice that two menu tests are failing.
  3. Notice that the tests are passing on CI.

Screenshots

These are the images produced when failing:

layout_shortcuts_other
layout_shortcuts_other_theme_changed

Example code

Part of tests. See errors bellow:

--- FAIL: TestMenu_Layout (0.49s)
    --- FAIL: TestMenu_Layout/menu_with_shortcuts (0.39s)
        util.go:55: 
            	Error Trace:	/var/home/jacob/git/fyne/internal/test/util.go:55
            	            				/var/home/jacob/git/fyne/test/test.go:78
            	            				/var/home/jacob/git/fyne/widget/menu_desktop_test.go:191
....
            	Error Trace:	/var/home/jacob/git/fyne/internal/test/util.go:55
            	            				/var/home/jacob/git/fyne/test/test.go:78
            	            				/var/home/jacob/git/fyne/widget/menu_desktop_test.go:195
            	            				/var/home/jacob/git/fyne/test/test.go:318
            	            				/var/home/jacob/git/fyne/widget/menu_desktop_test.go:194

Fyne version

develop@0e265645f3ab1604a854755f6a4d1ed1e18293a5

Go compiler version

1.22.4

Operating system and version

Fedora Silverblue 40

Additional Information

No response

@Jacalz Jacalz added bug Something isn't working blocker Items that would block a forthcoming release testing Issues related to tests and testing. labels Jun 25, 2024
@Jacalz Jacalz added this to the "Elgin" release, early 2024 milestone Jun 25, 2024
@andydotxyz
Copy link
Member

The tests are not failing locally for me.
I don't think this can be a blocker until we know what the actual cause is...

@Jacalz
Copy link
Member Author

Jacalz commented Jun 28, 2024

Did you test on Linux?

@andydotxyz
Copy link
Member

Yes, Debian stable.

@andydotxyz
Copy link
Member

Re-confirmed on latest develop - no test failures

@andydotxyz andydotxyz removed the blocker Items that would block a forthcoming release label Jun 30, 2024
@Jacalz
Copy link
Member Author

Jacalz commented Jun 30, 2024

Something strange is definitely going on. Will try to investigate when I have time. Not really a nice bug to have because it makes it a lot harder to do testing locally.

@andydotxyz
Copy link
Member

I'm sure it is frustrating - but so far we don't have reports of this failing for anyone else.

@andydotxyz andydotxyz changed the title Menu tests are failing locally but not on CI Menu tests are failing on some developer computers Jun 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working testing Issues related to tests and testing.
Projects
None yet
Development

No branches or pull requests

2 participants