Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests not discovered after updating xunit package from 2.3.1 to 2.4.0 (new csproj) #21

Open
PiotrBrzezianski opened this issue Aug 6, 2018 · 2 comments

Comments

@PiotrBrzezianski
Copy link

We're using xUnitAdapter with new csproj targeting net461 framework. Everything was working fine until recent update of xUnit NuGet package to version 2.4.0. Since then no tests are being discovered.

I'm attaching MyCalculator sample project converted to new csproj format with SpecFlow.xUnitAdapter.Config.cs file added and using SpecFlowEmbeddedFeature to add feature files.
Specflow.xUnitAdapter.xUnit24.Repro.zip

If I switch the package version back to 2.3.1 all test are discovered and pass as expected.

@mtrcn
Copy link

mtrcn commented Aug 6, 2018

Hi @PiotrBrzezianski,

https://github.com/gasparnagy/SpecFlow.xUnitAdapter/blob/master/src/SpecFlow.xUnitAdapter.SpecFlowPlugin/TestArtifacts/ScenarioTestCase.cs does not implement the new IXunitTestCase interface in 2.4.0 (https://github.com/xunit/xunit/blob/dabc047ce181813b886a3d0493bbeddbabf23a16/src/xunit.core/Sdk/IXunitTestCase.cs), so new two properties are missing (InitializationException and Timeout) in current version.

Regards,

@davidzwa
Copy link

Same problem here. Tried with .NET 4.5 to 4.7.2.

@mtrcn or @gasparnagy what might the solution be? Does it require a PR or does it require our intervention?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants