Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limited codec support despite using FFmpeg #20

Closed
ticky opened this issue Mar 25, 2020 · 4 comments · Fixed by #37
Closed

Limited codec support despite using FFmpeg #20

ticky opened this issue Mar 25, 2020 · 4 comments · Fixed by #37
Labels
enhancement New feature or request

Comments

@ticky
Copy link
Contributor

ticky commented Mar 25, 2020

FFmpeg is capable of decoding a lot more than WAV, MP3 and FLAC. It would be great for platinum-md to handle other codecs as well.

music-metadata likewise supports many, many formats, so even things like AAC, ALAC, APE, DSD, OGG and WMA would work with just removing this restriction.

If you wanted to be really, really correct about this, a way to still filter what files you scan with music-metadata might be to populate your list of accepted file extensions using the output of ffmpeg -demuxers, which lists, in the second column, the file extension or extensions, of these formats (significantly trimmed down for clarity):

File formats:
 D. = Demuxing supported
 .E = Muxing supported
 --
 D  aac             raw ADTS AAC (Advanced Audio Coding)
 D  ac3             raw AC-3
 D  aiff            Audio IFF
 D  alaw            PCM A-law
 D  ape             Monkey's Audio
 D  asf             ASF (Advanced / Active Streaming Format)
 D  caf             Apple CAF (Core Audio Format)
 D  dts             raw DTS
 D  dtshd           raw DTS-HD
 D  f32be           PCM 32-bit floating-point big-endian
 D  f32le           PCM 32-bit floating-point little-endian
 D  f64be           PCM 64-bit floating-point big-endian
 D  f64le           PCM 64-bit floating-point little-endian
 D  flac            raw FLAC
 D  mov,mp4,m4a,3gp,3g2,mj2 QuickTime / MOV
 D  mp3             MP2/3 (MPEG audio layer 2/3)
 D  ogg             Ogg
 D  oma             Sony OpenMG audio
 D  wv              WavPack
@gavinbenda
Copy link
Owner

Happy to add a whole bunch more in - have only added formats that I've tested so far.
Also need to refactor that code a little.

@gavinbenda gavinbenda added the enhancement New feature or request label Mar 25, 2020
@Invictaz
Copy link

@ticky could you also implement this fix?
dcherednik/atracdenc#9 (comment)

So that ATRAC3 files can directly be inputted as well to convert them to ATRAC1?
Platinum-MD uses "atracdenc" as well but not this fix yet I think.

@gavinbenda
Copy link
Owner

Effectively doing the same thing at the moment, as described here:

You can decode atrac3plus by ffmpeg to pcm and than encode pcm to atrac1. The result will be same.

Because there's no fluent API for atracdenc, it's probably better to keep things as it is, but happy to change if there's specific issues you're coming across at the moment.

You'll be pleased to know in the next release, it cleans up temp files after it's finished.

@Invictaz
Copy link

Invictaz commented Mar 26, 2020

@gavinbenda The only thing I would like to have is ATRAC3 -> ATRAC1. If your next release does cleanup the step in between and accepts ATRAC3 as input I'm fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants