Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an "unsupported" surface type to SphericalCoordinates #237

Open
chapulina opened this issue Sep 16, 2021 · 0 comments
Open

Add an "unsupported" surface type to SphericalCoordinates #237

chapulina opened this issue Sep 16, 2021 · 0 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@chapulina
Copy link
Contributor

Desired behavior

During gazebosim/gz-msgs#177 (comment), it was brought up that it would be convenient to provide an unsupported type to the SurfaceType enum so that we can explicitly express that an invalid type has been passed.

Alternatives considered

Keep it the way it is and force the class to always be valid. This makes it difficult to detect configuration errors.

Implementation suggestion

Add an enum at the end and keep it at the end as we add new types.

Additional context

This is something to consider not only for this enum, but for all our enums too.

@chapulina chapulina added enhancement New feature or request help wanted Extra attention is needed labels Sep 16, 2021
@osrf-triage osrf-triage added this to Inbox in Core development Sep 16, 2021
@chapulina chapulina removed this from Inbox in Core development Sep 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant