Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IPT testing - Camtrap DP resource from an archive - not all seems auto-mapped (BOM issue) #2303

Open
ManonGros opened this issue Jan 25, 2024 · 7 comments

Comments

@ManonGros
Copy link
Contributor

I am using a local version of the IPT 3 org/gbif/ipt/3.0-RC2-SNAPSHOT/ipt-3.0-RC2-20240124.165554-116.war

I uploaded this archived https://download-directory.github.io/?url=https://github.com/tdwg/camtrap-dp/tree/1.0/example to the IPT. And the observationIDs didn't seem to be found (even though the header and mapping seems correct?) The media license was also blank.

See the screenshot for the observationID.
Screenshot 2024-01-25 at 11 59 28
Screenshot 2024-01-25 at 12 01 13

issue for testing here: #2283

@mike-podolskiy90
Copy link
Contributor

mike-podolskiy90 commented Jan 25, 2024

Thanks Marie

I believe it's because of the BOM (byte order mark) character in the file. We need to ignore that character

@peterdesmet
Copy link
Member

Indeed, could you try https://download-directory.github.io/?url=https://github.com/tdwg/camtrap-dp/tree/188d285a3765f379f7c16ac2f542090cc1dfc86a/example (the latest commit on Camtrap DP where the BOM issue should be resolved)?

@mike-podolskiy90
Copy link
Contributor

Yes, it's fine

@ManonGros
Copy link
Contributor Author

Thanks! Yes the header is mapped but there is still no media license:

Screenshot 2024-01-25 at 13 24 55

I think there should be, right?
Screenshot 2024-01-25 at 13 25 31

@mike-podolskiy90
Copy link
Contributor

mike-podolskiy90 commented Jan 25, 2024

Yes, I'll be fixing that in the issue Andrea reported earlier #2295

@mike-podolskiy90 mike-podolskiy90 changed the title IPT testing - Camtrap DP resource from an archive - not all seems auto-mapped IPT testing - Camtrap DP resource from an archive - not all seems auto-mapped (BOM issue) Jan 25, 2024
@mike-podolskiy90
Copy link
Contributor

I think we need to require name field for the license. We need to display that on the UI. Otherwise we'll have to infer that from the path which I don't like

@mike-podolskiy90
Copy link
Contributor

BOM issue is not critical too I think

@mike-podolskiy90 mike-podolskiy90 modified the milestones: 3.0, 3.x Jan 25, 2024
@mike-podolskiy90 mike-podolskiy90 modified the milestones: 3.x, 3.1.0 Feb 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants