Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IPT allows publication of the resource with a project with no personnel #2425

Closed
mike-podolskiy90 opened this issue May 22, 2024 · 7 comments
Assignees
Milestone

Comments

@mike-podolskiy90
Copy link
Contributor

mike-podolskiy90 commented May 22, 2024

At least one personnel is required according to EML schema (both 2.1.1/2.2.0)
Although IPT saves the data without any issues and allows to publish it.

@mike-podolskiy90 mike-podolskiy90 self-assigned this May 22, 2024
@mike-podolskiy90 mike-podolskiy90 added this to the 3.1.0 milestone May 22, 2024
@mike-podolskiy90
Copy link
Contributor Author

Initially it wasn't like this, was changed here #1760
@gbif/dataproducts I'm afraid we need to revert it. Otherwise, we produce invalid EML.

@ahahn-gbif
Copy link
Contributor

We need to evaluate possible work-arounds. BID and BIFA (and other projects in the past) were never required to provide a project contact, and may not always be able to provide one when metadata updates fail for that reason.
Suggest to:

  • explore whether to enable and support use of a default value
  • provide easy-to-interpret error messages when dataset metadata cannot be saved/updated for that reason

@mike-podolskiy90
Copy link
Contributor Author

@gbif/dataproducts I'm going to start testing the EML update this week including this one. I don't think we can find a default value suitable for everyone here. So, I suppose, we just need to display a comprehensive error message.
Do you have any ideas/suggestions please?

@ManonGros
Copy link
Contributor

How about a message like "At least one project contact is now mandatory. Please add a contact person to the project tab." would that be ok? Maybe @ahahn-gbif has some better suggestion.

@mike-podolskiy90
Copy link
Contributor Author

Thanks Marie.

Do you want to display this message somewhere other than the project metadata page itself? Otherwise, we probably don't need to mention "to the project tab" if we're already on that page.

@ManonGros
Copy link
Contributor

@mike-podolskiy90 I am thinking of these cases where publishers have a dataset with a projectID and no project contact. They might just want to add records to their dataset and republish the archive without changing the metadata. In that case, I imagine that they won't be on the project tab when the error appears. They will likely be on the page that comes after pressing the publish button.

@mike-podolskiy90
Copy link
Contributor Author

I see. Yes, we need to display that on the resource overview page then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants