Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid running Dex in a fork #630

Closed
1 task
snizhana-dynnyk opened this issue Dec 9, 2021 · 9 comments
Closed
1 task

Avoid running Dex in a fork #630

snizhana-dynnyk opened this issue Dec 9, 2021 · 9 comments

Comments

@snizhana-dynnyk
Copy link
Contributor

Description

We are running a fork of Dex atm because we rely on support for the prefixing of group names with automatic id. These changes were declined upstream because they plan to implement middleware and design is far from being something that contributors agreed on.

Changes proposed upstream - dexidp/dex#2051
Alternative - https://github.com/giantswarm/giantswarm/issues/16933 Find a solution to avoid 'customer:' group name prefix

TODO

  • try to bring our contributions upstream
@marians
Copy link
Member

marians commented Feb 18, 2022

The upstream issue this is related to is

@marians
Copy link
Member

marians commented Feb 21, 2022

I just checked on the status upstream. It seems as if connector middlewares (which were the reason our PR was "rejected" or put on ice) don't have progressed at all.

@puja108 You commented there almost a year ago. Would it make sense if you could try again? Or should someone else?

The aspects we could mention are

  • Our implementation is tested in production with several connectors.
  • Middlewares have not progressed. Once they are here, the implementation could off course be changed.

@puja108
Copy link
Member

puja108 commented Feb 21, 2022

I'd prefer if you or someone from Rainbow would continue the conversation, so you can steer it better in the right direction. I would then still be available to +1 and/or escalate (and can take that role better then).

@marians
Copy link
Member

marians commented Feb 21, 2022

ACK, done

@ghost ghost added the epic/managed-dex label Mar 14, 2022
@anvddriesch
Copy link

Let's try again to contribute upstream now that all connectors work with prefixing.

@jonaz
Copy link

jonaz commented Mar 20, 2024

Did you manage to get this upstream?

@anvddriesch
Copy link

@jonaz unfortunately not. We were told that it might be part of dexidp/dex#1635 but the issue is still open.

@jonaz
Copy link

jonaz commented Mar 21, 2024

i did remind them here: dexidp/dex#918 (comment)

@gawertm
Copy link

gawertm commented Apr 30, 2024

no news upstream for 2 years, not sure if we are going to use dex in the future anyways, closing for now. will revisit when discussing future of Dex

@gawertm gawertm closed this as not planned Won't fix, can't repro, duplicate, stale Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

No branches or pull requests

7 participants