Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Model JSON merging? #2

Open
gniftygnome opened this issue Mar 10, 2023 · 2 comments
Open

Model JSON merging? #2

gniftygnome opened this issue Mar 10, 2023 · 2 comments

Comments

@gniftygnome
Copy link

I'm wondering if you have considered adding some client side merging (in my case, merging model JSONs would be really nice).

I've been working on adding armor trim materials for Cinderscapes, but it requires overwriting the vanilla item models, which really sucks. I just need to add a few overrides to them.

It would be great if I could recommend using a mod like yours to resolve problems when folks want to use Cinderscapes with another mod that also adds armor trims. (It would be even greater if Mojang will add this functionality themselves, but they do not seem to care...)

@gniftygnome
Copy link
Author

(I should have checked first, but now I see this is a Forge mod; I guess the question is still valid even though if you fix it that won't help me. heh)

@gigaherz
Copy link
Owner

It is something I guess I could do, but it's extremely specific, unlike the main coremod which works automatically for any data loader that uses the SimpleJsonResourceReloadListener. If you would actually use, it may make it worth my looking into it but yeah.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants