New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Proposal: vendor in nlopt #6

Open

edaniels opened this issue Feb 18, 2023 · 1 comment

Contributor

edaniels commented Feb 18, 2023

In order to make this library easier to use from most places, I'm wondering if statically linking nlopt is better. wasmer for go does this https://github.com/wasmerio/wasmer-go/blob/master/wasmer/cgo.go. It also allows doing this in a custom way https://github.com/wasmerio/wasmer-go/blob/master/wasmer/cgo_with_custom_wasmer_runtime.go. We could do something similar with the default being static and then dynamic being chosen.

I could put a PR for this but I wanted to get input first since it's a larger change with consequences.

Contributor

mbogus commented Feb 19, 2023

The suggestion seem very sound, happy to support the PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment